C++: Make XMLFile extend File again#92
Merged
Merged
Conversation
Commit a1e4404 made `XMLFile` no longer extend `File`. I'm guessing this was necessary in the branch where `File` was an IPA-typed `Element` and `XMLFile` was not, but it broke compilation of some of our internal queries.
ian-semmle
approved these changes
Aug 23, 2018
smowton
added a commit
to smowton/codeql
that referenced
this pull request
Dec 6, 2021
…ypes Array types: record dimensionality
dbartol
pushed a commit
that referenced
this pull request
Dec 18, 2024
Improve path checks for Artifact and Cache poisoning queries
MathiasVP
added a commit
to MathiasVP/ql
that referenced
this pull request
Aug 10, 2025
PS: Add dataflow skeleton
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit a1e4404 made
XMLFileno longer extendFile. I'm guessing this was necessary in the branch whereFilewas an IPA-typedElementandXMLFilewas not, but it broke compilation of some of our internal queries.The proper fix may be to make
XMLFileanElementor to change the code that doesn't compile, but for now I propose this quick fix.