Skip to content

JS: promote the js/missing-origin-verification query #8724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erik-krogh merged 11 commits into from
May 9, 2022
Merged

JS: promote the js/missing-origin-verification query #8724

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
18532ba
move js/missing-postmessageorigin-verification out of experimental
erik-krogh Apr 8, 2022
ec9c308
reorganize the tests in CWE-020
erik-krogh Apr 8, 2022
e2badab
update expected output after test reorganization
erik-krogh Apr 8, 2022
2d6d304
add `InclusionTest` to `PostMessageEventSanitizer`
erik-krogh Apr 12, 2022
591fcda
various improvements to the js/missing-origin-verification query
erik-krogh Apr 12, 2022
bca4d14
rename files
erik-krogh Apr 12, 2022
df295e6
add change-note
erik-krogh Apr 12, 2022
fe3d71e
fix qhelp: the window, not the origin, is sending the message
erik-krogh Apr 25, 2022
0a26e89
include startsWith/endsWith checks in js/missing-origin-check
erik-krogh Apr 25, 2022
2d7c7ff
apply suggestions from doc review
erik-krogh May 5, 2022
58db922
add missing word in qhelp
erik-krogh May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix qhelp: the window, not the origin, is sending the message 
Co-authored-by: Esben Sparre Andreasen <esbena@github.com>
  • Loading branch information
@erik-krogh @esbena
erik-krogh and esbena authored Apr 25, 2022
commit fe3d71ebc21dc225a37bcad3d1da3e2d0aed610a
3 changes: 1 addition & 2 deletions javascript/ql/src/Security/CWE-020/MissingOriginCheck.qhelp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@

<p>
The <code>"message"</code> event is used to send messages between windows.
An untrusted origin is allowed to send messages to a trusted window, and if the origin
is not checked that can lead to various security issues.
An untrusted window can send a message to a trusted window, and it is up to the receiver to verify the legitimacy of the message. One way of doing that verification is to check the <code>origin</code> of the message ensure that it origins from a trusted window.
Comment thread
erik-krogh marked this conversation as resolved.
Outdated
</p>
</overview>

Expand Down