Skip to content

[Java] Add CharacterLiteral to CompileTimeConstantExpr.getStringValue #8325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atorralba merged 3 commits into from
Mar 7, 2022
Merged

[Java] Add CharacterLiteral to CompileTimeConstantExpr.getStringValue #8325

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04cd0db
[Java] Add CharacterLiteral to CompileTimeConstantExpr.getStringValue
JLLeitschuh Mar 3, 2022
17b6e66
Apply suggestions from code review
JLLeitschuh Mar 4, 2022
38897f2
Fixup tests from code review changes
JLLeitschuh Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Tony Torralba <atorralba@users.noreply.github.com>
  • Loading branch information
@JLLeitschuh @atorralba
JLLeitschuh and atorralba authored Mar 4, 2022
commit 17b6e66814f7f6d39f02c8c353af1a8ffdea156b
4 changes: 2 additions & 2 deletions java/ql/test/library-tests/constants/constants/Values.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ void values(final int notConstant) {
int var_local = final_local; //42
int var_param = notConstant; //Not constant
int var_nonfinald_local = var_field; //Not constant
String concatinatedString = "a" + "b"; //ab
String concatinatedChar = "ab" + 'c'; //abc
String concatenatedString = "a" + "b"; //ab
String concatenatedChar = "ab" + 'c'; //abc
}
}
4 changes: 2 additions & 2 deletions java/ql/test/library-tests/constants/getStringValue.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import semmle.code.java.Variable

from Variable v, Expr init, RefType enclosing, string constant
from Variable v, CompileTimeConstantExpr init, RefType enclosing, string constant
where
v.getInitializer() = init and
init.getEnclosingCallable().getDeclaringType() = enclosing and
enclosing.hasQualifiedName("constants", "Values") and
constant = init.(CompileTimeConstantExpr).getStringValue()
constant = init.getStringValue()
select init, constant