Skip to content

CPP: Add query for CWE-754: Improper Check for Unusual or Exceptional Conditions when using functions scanf #8246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jketema merged 22 commits into from
Mar 11, 2022
Merged

CPP: Add query for CWE-754: Improper Check for Unusual or Exceptional Conditions when using functions scanf #8246

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
3d1f4d5
Merge pull request #1 from github/main
ihsinme Feb 25, 2022
bddb5fd
Add files via upload
ihsinme Feb 25, 2022
0c8a072
Add files via upload
ihsinme Feb 25, 2022
d772ea0
Apply suggestions from code review
ihsinme Mar 1, 2022
bfec3c5
Update ImproperCheckReturnValueScanf.expected
ihsinme Mar 1, 2022
e9fefab
Update test.cpp
ihsinme Mar 1, 2022
a6654fc
Update ImproperCheckReturnValueScanf.ql
ihsinme Mar 1, 2022
1a30b8d
Apply suggestions from code review
ihsinme Mar 3, 2022
547342c
Update test.cpp
ihsinme Mar 3, 2022
2dc85e1
Update test.cpp
ihsinme Mar 3, 2022
25b3aba
Update test.cpp
ihsinme Mar 3, 2022
8e0c0ad
Update test.cpp
ihsinme Mar 3, 2022
bec4170
Update ImproperCheckReturnValueScanf.expected
ihsinme Mar 3, 2022
01f9114
Update test.cpp
ihsinme Mar 3, 2022
c0c7748
Apply suggestions from code review
ihsinme Mar 8, 2022
8335778
Update ImproperCheckReturnValueScanf.qhelp
ihsinme Mar 8, 2022
5e23615
Update test.cpp
ihsinme Mar 10, 2022
4b451cf
Update ImproperCheckReturnValueScanf.expected
ihsinme Mar 10, 2022
fa3ce61
Update test.cpp
ihsinme Mar 10, 2022
a094e6f
Update test.cpp
ihsinme Mar 10, 2022
623f3fb
Update test.cpp
ihsinme Mar 10, 2022
ac8adea
Update ImproperCheckReturnValueScanf.expected
ihsinme Mar 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update test.cpp
  • Loading branch information
@ihsinme
ihsinme authored Mar 3, 2022
commit 2dc85e183c56cf381c3f1bc03b589c4ea04bd3f0
6 changes: 5 additions & 1 deletion cpp/ql/test/experimental/query-tests/Security/CWE/CWE-754/semmle/tests/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,18 @@ int functionWork1_() {
return i;
}

int functionWork1b() {
int functionWork1b(int retIndex) {
int i;
char a[10];
int b;
int *p = &b;
scanf("%i", &i); // BAD
scanf("%s", a); // BAD
scanf("%i", p); // BAD
Comment thread
ihsinme marked this conversation as resolved.
if(retIndex == 0)
return (int)a;
if(retIndex == 1)
return *p;
return i;
}

Expand Down