Skip to content

Java: Add support for bitwise compound assignments in Guards. #7698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aschackmull merged 2 commits into from
Jan 24, 2022
Merged

Java: Add support for bitwise compound assignments in Guards. #7698

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41d2942
Java: Add support for bitwise compound assignments in Guards.
aschackmull Jan 21, 2022
5f7ee33
Java: Use more set literal syntax.
aschackmull Jan 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Java: Use more set literal syntax.
  • Loading branch information
@aschackmull
aschackmull committed Jan 21, 2022
commit 5f7ee337cde3c811e042353e14410e3a58ca9670
10 changes: 5 additions & 5 deletions java/ql/lib/semmle/code/java/controlflow/internal/GuardsLogic.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,13 @@ predicate implies_v1(Guard g1, boolean b1, Guard g2, boolean b2) {
or
g1.(LogNotExpr).getExpr() = g2 and
b1 = b2.booleanNot() and
(b1 = true or b1 = false)
b1 = [true, false]
or
exists(EqualityTest eqtest, boolean polarity, BooleanLiteral boollit |
eqtest = g1 and
eqtest.hasOperands(g2, boollit) and
eqtest.polarity() = polarity and
(b1 = true or b1 = false) and
b1 = [true, false] and
b2 = b1.booleanXor(polarity).booleanXor(boollit.getBooleanValue())
)
or
Expand All @@ -60,7 +60,7 @@ predicate implies_v1(Guard g1, boolean b1, Guard g2, boolean b2) {
exists(MethodAccess check | check = g1 |
conditionCheck(check, _) and
g2 = check.getArgument(0) and
(b1 = true or b1 = false) and
b1 = [true, false] and
b2 = b1
)
or
Expand All @@ -69,7 +69,7 @@ predicate implies_v1(Guard g1, boolean b1, Guard g2, boolean b2) {
vbool.getDefiningExpr().(AssignOp) = g2
|
vbool.getAUse() = g1 and
(b1 = true or b1 = false) and
b1 = [true, false] and
b2 = b1
)
or
Expand All @@ -91,7 +91,7 @@ predicate implies_v2(Guard g1, boolean b1, Guard g2, boolean b2) {
vbool.getDefiningExpr().(AssignOp) = g2
|
vbool.getAUse() = g1 and
(b1 = true or b1 = false) and
b1 = [true, false] and
b2 = b1
)
or
Expand Down