C#: Fix some LGTM alerts on the extractor#755
Merged
Conversation
Contributor
|
This pull request fixes 5 alerts when merging de4f592 into b0dd3df - view on LGTM.com fixed alerts:
Comment posted by LGTM.com |
hvitved
reviewed
Jan 11, 2019
hvitved
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just two comments.
| { | ||
| var other = obj as CachedEntity<Initializer>; | ||
| return obj != null && obj.GetType() == GetType() && Equals(other.symbol, symbol); | ||
| return other != null && other.GetType() == GetType() && Equals(other.symbol, symbol); |
Contributor
There was a problem hiding this comment.
Could replace other != null && other.GetType() == GetType() with other?.GetType() == GetType()
| } | ||
| } | ||
| catch (Exception ex) | ||
| catch (Exception ex) // lgtm[cs/catch-of-all-exceptions] |
Contributor
There was a problem hiding this comment.
Perhaps we should disable this query in the .lgtm.yml file instead?
Contributor
Author
There was a problem hiding this comment.
I think leave this, because it would be in principle a good idea to receive new alerts for cs/catch-of-all-exceptions if we introduce new ones.
Contributor
|
This pull request fixes 4 alerts when merging e76eb16 into dcdbc00 - view on LGTM.com fixed alerts:
Comment posted by LGTM.com |
hvitved
approved these changes
Jan 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.