Skip to content

Java: Experimental query for Log4j JNDI Injection #7354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smowton merged 5 commits into from
Dec 14, 2021
Merged

Java: Experimental query for Log4j JNDI Injection #7354

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
43a1045
[Java] Query for Log4j JNDI Injection
atorralba Dec 10, 2021
d2dc199
Apply suggestions from code review
atorralba Dec 13, 2021
ff2f5a5
Apply suggestions from code review
atorralba Dec 13, 2021
1b761b3
Apply suggestions from code review
atorralba Dec 13, 2021
aee617f
Autoformat
atorralba Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Bas van Schaik <5082246+sj@users.noreply.github.com>
  • Loading branch information
@atorralba @sj
atorralba and sj authored Dec 13, 2021
commit ff2f5a5f91c3c5c0a89afddad5f1e1f7458f4351
7 changes: 3 additions & 4 deletions java/ql/src/experimental/Security/CWE/CWE-020/Log4jJndiInjection.qhelp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,14 @@ From Log4j 2.15.0, this behavior has been disabled by default. Note that this qu
This issue was remediated in Log4j v2.15.0. The Apache Logging Services team provides the following mitigation advice:
</p>
<p>
In previous releases (>=2.10) this behavior can be mitigated by setting system property "log4j2.formatMsgNoLookups" to “true”
or by removing the JndiLookup class from the classpath (example: zip -q -d log4j-core-*.jar org/apache/logging/log4j/core/lookup/JndiLookup.class).
Java 8u121 protects against RCE by defaulting "com.sun.jndi.rmi.object.trustURLCodebase" and "com.sun.jndi.cosnaming.object.trustURLCodebase" to "false".
In previous releases (>=2.10) this behavior can be mitigated by setting system property <code>log4j2.formatMsgNoLookups</code> to <code>true</code>
or by removing the <code>JndiLookup</code> class from the classpath (example: <code>zip -q -d log4j-core-*.jar org/apache/logging/log4j/core/lookup/JndiLookup.class</code>).
</p>
<p>
You can manually check for use of affected versions of Log4j by searching your project repository for Log4j use, which is often in a pom.xml file.
</p>
<p>
Where possible, upgrade to Log4J version 2.15.0. If you are using Log4J v1 there is a migration guide available.
Where possible, upgrade to Log4j version 2.15.0. If you are using Log4j v1 there is a migration guide available.
</p>
<p>
Please note that Log4j v1 is End Of Life (EOL) and will not receive patches for this issue. Log4j v1 is also vulnerable to other RCE vectors and we
Expand Down