Ruby: add getMethodName predicate to DataFlow::CallNode class#7151
Merged
Conversation
aibaars
reviewed
Nov 16, 2021
|
|
||
| /** A data-flow node corresponding to a method call in the control-flow graph. */ | ||
| class MethodCallNode extends CallNode { | ||
| private CfgNodes::ExprNodes::MethodCallCfgNode node; |
Contributor
There was a problem hiding this comment.
Make the super class field non-private and
Suggested change
| private CfgNodes::ExprNodes::MethodCallCfgNode node; | |
| override CfgNodes::ExprNodes::MethodCallCfgNode node; |
Alternatively, just add the getMethodName method directly to CallNode. I think it is fine for that method to return none() in case the underlying Call is not a MethodCall.
Contributor
Author
There was a problem hiding this comment.
I like the idea of moving getMethodName into CallNode, as the predicate name implies that we are interested in method calls.
DataFlow::MethodCallNode classgetMethodName predicate to DataFlow::CallNode class
hvitved
approved these changes
Nov 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets us tidy up a few places where we have a
DataFlow::CallNodewith an underlyingMethodCall, but have to do a clumsynode.asExpr().getExpr().(MethodCall)cast in order to get the name of the called method.