Skip to content

C++: Minor improvements to 'Failure to use HTTPS URLs' query#7149

Merged
geoffw0 merged 3 commits into
github:mainfrom
geoffw0:non-https-url2
Nov 17, 2021
Merged

C++: Minor improvements to 'Failure to use HTTPS URLs' query#7149
geoffw0 merged 3 commits into
github:mainfrom
geoffw0:non-https-url2

Conversation

@geoffw0
Copy link
Copy Markdown
Contributor

@geoffw0 geoffw0 commented Nov 16, 2021

Minor improvements to the query recently added in #7094:

  • add a CWE tag that should effectively associate the query with OWASP A8.
  • add a few more sinks (functions that take a URL as a parameter).

@geoffw0 geoffw0 added C++ no-change-note-required This PR does not need a change note labels Nov 16, 2021
@geoffw0 geoffw0 requested a review from a team as a code owner November 16, 2021 13:55
MathiasVP
MathiasVP previously approved these changes Nov 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@geoffw0 geoffw0 merged commit d232283 into github:main Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MathiasVP MathiasVP MathiasVP approved these changes

Assignees

No one assigned

Labels

C++ no-change-note-required This PR does not need a change note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@geoffw0 @MathiasVP