Skip to content

Java: Promote Log Injection from experimental #7054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atorralba merged 12 commits into from
Jan 11, 2022
Merged

Java: Promote Log Injection from experimental #7054

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7f15177
Move from experimental
atorralba Oct 29, 2021
3ea1af3
Refactor into separate libraries
atorralba Oct 29, 2021
ebd6529
WIP: add tests
atorralba Nov 2, 2021
7d88f80
Add tests for summaries
atorralba Nov 3, 2021
f1df542
Add stubs & tests
atorralba Nov 3, 2021
474bf57
Minor corrections in QLDoc, qhelp and example code
atorralba Nov 4, 2021
ea7e259
Add change note
atorralba Nov 4, 2021
6613a98
Fix references to logging library
atorralba Nov 4, 2021
0e73862
Merge branch 'main' into atorralba/promote-log-injection
atorralba Jan 10, 2022
fbebf5e
Move change note to new location
atorralba Jan 10, 2022
b9e3220
Move change note to new location
atorralba Jan 11, 2022
1030ff7
Update java/ql/src/Security/CWE/CWE-117/LogInjection.ql
atorralba Jan 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add stubs & tests 
Fix mistakes detected by the tests
  • Loading branch information
@atorralba
atorralba committed Nov 3, 2021
commit f1df5423450b2888ed68af2bb6d8c339e8d439ff
261 changes: 177 additions & 84 deletions java/ql/lib/semmle/code/java/frameworks/Logging.qll
View file
Open in desktop

Large diffs are not rendered by default.

Empty file added java/ql/test/query-tests/security/CWE-117/LogInjectionTest.expected
View file
Open in desktop
Empty file.
1,956 changes: 1,956 additions & 0 deletions java/ql/test/query-tests/security/CWE-117/LogInjectionTest.java
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 6 additions & 0 deletions java/ql/test/query-tests/security/CWE-117/LogInjectionTest.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@ import java
import semmle.code.java.security.LogInjectionQuery
import TestUtilities.InlineFlowTest

private class TestSource extends RemoteFlowSource {
TestSource() { this.asExpr().(MethodAccess).getMethod().hasName("source") }

override string getSourceType() { result = "test source" }
}

private class LogInjectionTest extends InlineFlowTest {
override DataFlow::Configuration getValueFlowConfig() { none() }

Expand Down
1 change: 1 addition & 0 deletions java/ql/test/query-tests/security/CWE-117/options
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
//semmle-extractor-options: --javac-args -cp ${testdir}/../../../stubs/apache-log4j-1.2.17:${testdir}/../../../stubs/apache-log4j-2.14.1:${testdir}/../../../stubs/apache-commons-logging-1.2:${testdir}/../../../stubs/jboss-logging-3.4.2:${testdir}/../../../stubs/slf4j-2.0.0:${testdir}/../../../stubs/scijava-common-2.87.1:${testdir}/../../../stubs/flogger-0.7.1:${testdir}/../../../stubs/google-android-9.0.0
52 changes: 52 additions & 0 deletions java/ql/test/stubs/apache-commons-logging-1.2/org/apache/commons/logging/Log.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

47 changes: 47 additions & 0 deletions java/ql/test/stubs/apache-log4j-1.2.17/org/apache/log4j/Appender.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

181 changes: 181 additions & 0 deletions java/ql/test/stubs/apache-log4j-1.2.17/org/apache/log4j/Category.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 25 additions & 0 deletions java/ql/test/stubs/apache-log4j-1.2.17/org/apache/log4j/Layout.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 26 additions & 0 deletions java/ql/test/stubs/apache-log4j-1.2.17/org/apache/log4j/Level.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

31 changes: 31 additions & 0 deletions java/ql/test/stubs/apache-log4j-1.2.17/org/apache/log4j/Logger.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading