Skip to content

Python: Model flask_admin#7033

Merged
tausbn merged 5 commits into
github:mainfrom
RasmusWL:flask-admin
Nov 12, 2021
Merged

Python: Model flask_admin#7033
tausbn merged 5 commits into
github:mainfrom
RasmusWL:flask-admin

Conversation

@RasmusWL
Copy link
Copy Markdown
Member

@RasmusWL RasmusWL commented Nov 2, 2021

No description provided.

@RasmusWL
Copy link
Copy Markdown
Member Author

RasmusWL commented Nov 4, 2021

Results from performance evaluation looks fine 👍

tausbn
tausbn previously approved these changes Nov 11, 2021
Copy link
Copy Markdown
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments, but they're really minor.

Other than that it looks good! 💪

Comment thread python/ql/lib/semmle/python/frameworks/FlaskAdmin.qll Outdated
Comment thread python/ql/src/meta/alerts/RequestHandlers.ql
Copy link
Copy Markdown
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@tausbn tausbn merged commit 55ea715 into github:main Nov 12, 2021
@RasmusWL RasmusWL deleted the flask-admin branch November 12, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants