Data flow: Restrict derived flow summaries#6931
Merged
aschackmull merged 6 commits intoNov 18, 2021
Merged
Conversation
4a4fd46 to
b25ca39
Compare
b25ca39 to
de7a0dd
Compare
de7a0dd to
4eacbd1
Compare
aschackmull
approved these changes
Nov 18, 2021
Contributor
aschackmull
left a comment
There was a problem hiding this comment.
LGTM. I've looked into one of the removed jdk results and that was a FP arising from the previous handling of derived summaries, as the post-to-pre edge for parameters caused weird interactions with modelled methods that also happened to have a concrete body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restricts how we generate derived flow summaries, to avoid spurious flow.
For derived fluent flow, this is now restricted to summaries where a parameter is returned (possibly in a (nested) field).
For derived flow through callback parameters, this is now restricted to summaries that are not themselves derived.