Python: Type tracker changes#6858
Merged
Merged
Conversation
tausbn
previously approved these changes
Oct 25, 2021
Contributor
tausbn
left a comment
There was a problem hiding this comment.
One minor suggestion, otherwise LGTM. 👍
Member
|
@hvitved I think just accepting the suggestion caused trouble due to the file being synchronized 😳 |
71592d2 to
fe80c4a
Compare
Contributor
Author
Yes, this happened because the PR was created before Ruby got merged into the repo. I have rebased the PR and synchronized the Ruby copy. |
tausbn
approved these changes
Nov 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit caches
TypeBackTracker::prepend, similar to howTypeTracker::appendis cached.The second commit introduces a new predicate
TypeBackTracker::getACompatibleTypeTracker(), which is useful when reasoning about nodes that can be reached in both forwards tracking and backwards tracking.