Skip to content

Java: Create new query Cleartext storage of sensitive information in Android filesystem #6576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atorralba merged 8 commits into from
Jan 17, 2022
Merged

Java: Create new query Cleartext storage of sensitive information in Android filesystem #6576

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c1ac09a
Added query for Cleartext Storage in Android Filesystem
atorralba Sep 3, 2021
79ddbd6
Fix QLDoc and the qhelp example
atorralba Sep 3, 2021
1e4840e
Fix predicate name
atorralba Nov 11, 2021
9bbba3c
Adjust UnsupportedExternalAPIs test
atorralba Nov 11, 2021
22aad17
Apply review suggestions
atorralba Nov 12, 2021
d9e6e5a
Apply suggestions from code review
atorralba Jan 17, 2022
500deac
Change query description
atorralba Jan 17, 2022
ba3a4fb
Rename filesystemStore predicate after d9e6e5aa04e550e7226c80ae468a2f…
atorralba Jan 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Rename filesystemStore predicate after d9e6e5a
  • Loading branch information
@atorralba
atorralba committed Jan 17, 2022
commit ba3a4fb717eedda20c3cf2a7bd07d97d29115eb5
16 changes: 8 additions & 8 deletions java/ql/lib/semmle/code/java/security/CleartextStorageAndroidFilesystemQuery.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class LocalFileOpenCall extends Storable {

override Expr getAStore() {
exists(FilesystemFlowConfig conf, DataFlow::Node n |
filesystemStore(n, result) and
closesFile(n, result) and
conf.hasFlow(DataFlow::exprNode(this), n)
)
}
Expand All @@ -57,14 +57,14 @@ private predicate isVarargs(Argument arg, DataFlow::ImplicitVarargsArray varargs

/** Holds if `store` closes `file`. */
private predicate closesFile(DataFlow::Node file, Call closeCall) {
store.getCallee() instanceof CloseFileMethod and
if store.getCallee().isStatic()
then file.asExpr() = store
else file.asExpr() = store.getQualifier()
closeCall.getCallee() instanceof CloseFileMethod and
if closeCall.getCallee().isStatic()
then file.asExpr() = closeCall
else file.asExpr() = closeCall.getQualifier()
or
// try-with-resources automatically closes the file
any(TryStmt try).getAResource() = store.(LocalFileOpenCall).getEnclosingStmt() and
store = file.asExpr()
any(TryStmt try).getAResource() = closeCall.(LocalFileOpenCall).getEnclosingStmt() and
closeCall = file.asExpr()
}

/** A method that closes a file, perhaps after writing some data. */
Expand All @@ -87,7 +87,7 @@ private class FilesystemFlowConfig extends DataFlow::Configuration {

override predicate isSink(DataFlow::Node sink) {
filesystemInput(sink, _) or
filesystemStore(sink, _)
closesFile(sink, _)
}

override predicate isAdditionalFlowStep(DataFlow::Node node1, DataFlow::Node node2) {
Expand Down