Skip to content

Java: Refactor Cleartext Storage queries #6493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aschackmull merged 5 commits into from
Sep 23, 2021
Merged

Java: Refactor Cleartext Storage queries #6493

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a30554e
Refactored cleartext storage libraries
atorralba Aug 17, 2021
563e8a2
Remove unused library
atorralba Sep 3, 2021
51d2b52
Remove cached property from SensitiveSource::flowsTo
atorralba Sep 14, 2021
d0b9920
Fix encryption sanitizer
atorralba Sep 14, 2021
b52a2cd
Apply code review comments
atorralba Sep 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix encryption sanitizer 
It now discards sensitive exprs (sources) instead of sinks for better precision
  • Loading branch information
@atorralba
atorralba committed Sep 23, 2021
commit d0b9920cac5c762358cda00ba57c24e6c9cf2eb4
2 changes: 1 addition & 1 deletion java/ql/lib/semmle/code/java/security/CleartextStorageQuery.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ private class EncryptedValueFlowConfig extends DataFlow4::Configuration {
src.asExpr() instanceof EncryptedSensitiveMethodAccess
}

override predicate isSink(DataFlow::Node sink) { sink instanceof CleartextStorageSink }
override predicate isSink(DataFlow::Node sink) { sink.asExpr() instanceof SensitiveExpr }
}

/** A taint step for `EditText.toString` in Android. */
Expand Down