Skip to content

Python: CWE-117 Log injection #6182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yoff merged 5 commits into from
Oct 12, 2021
Merged

Python: CWE-117 Log injection #6182

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c60eded
Fix conflicting
haby0 Sep 15, 2021
9916753
Modify sinks
haby0 Sep 17, 2021
6c07a3e
Apply @yoff's suggestion
haby0 Sep 22, 2021
29ddc76
Update python/ql/test/experimental/query-tests/Security/CWE-117/LogIn…
haby0 Oct 11, 2021
d52f95d
Auto Formatting
haby0 Oct 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update python/ql/test/experimental/query-tests/Security/CWE-117/LogIn… 
…jection.expected

Co-authored-by: yoff <lerchedahl@gmail.com>
  • Loading branch information
@haby0 @yoff
haby0 and yoff authored Oct 11, 2021
commit 29ddc76e2fda9706ff8e92e31d27a12d29995e8a
1 change: 1 addition & 0 deletions python/ql/test/experimental/query-tests/Security/CWE-117/LogInjection.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ nodes
| LogInjectionBad.py:35:12:35:18 | ControlFlowNode for request | semmle.label | ControlFlowNode for request |
| LogInjectionBad.py:35:12:35:23 | ControlFlowNode for Attribute | semmle.label | ControlFlowNode for Attribute |
| LogInjectionBad.py:37:19:37:38 | ControlFlowNode for BinaryExpr | semmle.label | ControlFlowNode for BinaryExpr |
subpaths
#select
Comment thread
haby0 marked this conversation as resolved.
| LogInjectionBad.py:18:21:18:40 | ControlFlowNode for BinaryExpr | LogInjectionBad.py:17:12:17:18 | ControlFlowNode for request | LogInjectionBad.py:18:21:18:40 | ControlFlowNode for BinaryExpr | $@ flows to log entry. | LogInjectionBad.py:17:12:17:18 | ControlFlowNode for request | User-provided value |
| LogInjectionBad.py:24:18:24:37 | ControlFlowNode for BinaryExpr | LogInjectionBad.py:23:12:23:18 | ControlFlowNode for request | LogInjectionBad.py:24:18:24:37 | ControlFlowNode for BinaryExpr | $@ flows to log entry. | LogInjectionBad.py:23:12:23:18 | ControlFlowNode for request | User-provided value |
Expand Down