Python: Fix concept tests pretty print - #5878
Merged
Merged
Conversation
So we're consistenly using `expr` and not leaving our the `r`.
This required quite some changes in the expected output. I think it's much more clear what the selected nodes are now 👍 (but it was a bit boring work to fix this up)
This is better, since the modeling is also part of Stdlib.qll
See how this works in `test_json.py`
RasmusWL
force-pushed
the
fix-concept-tests-pretty-print
branch
from
May 19, 2021 15:10
95013a6 to
61ad5d0
Compare
RasmusWL
marked this pull request as ready for review
May 19, 2021 15:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So we can actually show
PostUpdateNotesDraft right now, since its based on top of the changes in #5864