JS: Improve tracking of route handlers and fix a rate-limiting FN/FP#5748
Merged
Conversation
erik-krogh
approved these changes
Apr 22, 2021
Contributor
erik-krogh
left a comment
There was a problem hiding this comment.
Looks good 👍
The refactorings make sense, and the DB didn't grow even though we cache more 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracks route handler functions through functions like this
It moves some of route-handler specific tracking into
DataFlow::functionOneWayForwardingStep, analogous toDataFlow::functionForwardingStep. The logic in the two steps is very similar so having them in one place makes it easier to keep them in sync.The step is used in route-handler tracking, but also in a few other places that were needed for the rate-limiting query to recognize wrapped rate limiters.
Commit-by-commit review strongly recommended as there's a lot of code being moved into another file, making the global diff hard to read.
Evaluation looks OK.