Skip to content

Java: Regex injection #5704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aschackmull merged 7 commits into from Jun 1, 2021
Merged

Java: Regex injection #5704

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
29e3206
Regex injection
Apr 16, 2021
13655b5
Add RegExUtils
Apr 21, 2021
452ec8c
comments
Apr 21, 2021
9774b24
Use TypeString
Apr 22, 2021
86444bf
Use set literal expression
Apr 22, 2021
ade2383
Add a test
Apr 22, 2021
5eb96c1
Remove Class cast
Apr 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use set literal expression
  • Loading branch information
edvraa committed Apr 22, 2021
commit 86444bfa09e2e48ec37801abf3b80d537dce4f92
24 changes: 6 additions & 18 deletions java/ql/src/experimental/Security/CWE/CWE-730/RegexInjection.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,35 +27,23 @@ class RegexSink extends DataFlow::ExprNode {
m.getDeclaringType() instanceof TypeString and
(
Comment thread
This conversation was marked as resolved.
ma.getArgument(0) = this.asExpr() and
(
m.hasName("matches") or
m.hasName("split") or
m.hasName("replaceFirst") or
m.hasName("replaceAll")
)
m.hasName(["matches", "split", "replaceFirst", "replaceAll"])
)
or
m.getDeclaringType().hasQualifiedName("java.util.regex", "Pattern") and
(
ma.getArgument(0) = this.asExpr() and
(
m.hasName("compile") or
m.hasName("matches")
)
m.hasName(["compile", "matches"])
)
or
m.getDeclaringType().hasQualifiedName("org.apache.commons.lang3", "RegExUtils") and
(
ma.getArgument(1) = this.asExpr() and
m.getParameterType(1).(Class) instanceof TypeString and
Comment thread
This conversation was marked as resolved.
Outdated
(
m.hasName("removeAll") or
m.hasName("removeFirst") or
m.hasName("removePattern") or
m.hasName("replaceAll") or
m.hasName("replaceFirst") or
m.hasName("replacePattern")
)
m.hasName([
"removeAll", "removeFirst", "removePattern", "replaceAll", "replaceFirst",
"replacePattern"
])
)
)
)
Expand Down