Skip to content

Python: Use API graphs in Werkzeug#5671

Merged
RasmusWL merged 2 commits into
github:mainfrom
tausbn:python-use-api-graphs-in-werkzeug
Apr 14, 2021
Merged

Python: Use API graphs in Werkzeug#5671
RasmusWL merged 2 commits into
github:mainfrom
tausbn:python-use-api-graphs-in-werkzeug

Conversation

@tausbn

@tausbn tausbn commented Apr 13, 2021

Copy link
Copy Markdown
Contributor

Deprecates the old InstanceSource classes, as these were non-private.

@tausbn tausbn requested a review from a team as a code owner April 13, 2021 16:05

@RasmusWL RasmusWL left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I agree with the deprecation strategy here. The whole point about extending MultiDict::InstanceSource and FileStorage::InstanceSource is that you want the additional taint steps to kick in. With these changes, if anyone else than us has done this (and I HIGHLY doubt this), their code would still run, but it would not work anymore (since the additional taint steps only kicks in if you use InstanceSourceApiNode).

I probably should have labeled these as INTERNAL: Do not use. when adding them 😞 but that's too late now. I suggest we either:

  1. Remove all traces of MultiDict::InstanceSource and FileStorage::InstanceSource, and take on the risk breaking someones code they actually these.
  2. commit to following our deprecation policy, such that the functionality you expect from MultiDict::InstanceSource and FileStorage::InstanceSource is still working even though they are deprecated.

I'm leaning towards option (1), since I think the chance of someone else than us having used these is 0%, and that keeping these deprecated versions functional is going to slow us down.

@RasmusWL RasmusWL left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From internal discussion I learned that this way of deprecating this is ok. I'm personally not 100% in agreement, but I'm going to try and not make too much of a fuzz about it.

In any case, I think absolutely no one would have used this anyway, so let us just go ahead with it 👍

@RasmusWL RasmusWL merged commit 44d2bf4 into github:main Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants