Good day.
maybe I need to do something else for this PR?

Hi @ihsinme,

Thanks for another contribution. Sorry we haven't got around to reviewing your PR yet, but it's on our radar :) You will get a review very soon!

I've done an initial run on LGTM: https://lgtm.com/query/1099721324323715668/

Most of those results are true positives, but there's one false positive here using a custom my_bool typedef. It may be worth checking for typedefs that include bool in the name to handle that kind of pattern.

Thanks for the query and for including the test and example.

thanks for your corrections.
they are really important for this PR and for me personally.

I've done an initial run on LGTM: https://lgtm.com/query/1099721324323715668/

Most of those results are true positives, but there's one false positive here using a custom my_bool typedef. It may be worth checking for typedefs that include bool in the name to handle that kind of pattern.

thanks for the bug found.
I suggest removing it based on criteria for using a variable outside of a condition, such as a boolean assignment.
https://lgtm.com/query/5898528743679763635/
if you agree with this fix, I will make the changes to the PR.

to avoid losing the situation when the developer got confused and named the variables of different types the same.
I slightly improved the query from the previous comment.
https://lgtm.com/query/2974469014939045566/

good day.
I hope I have corrected all your comments.

Ping @rdmarsh2.

thanks