Skip to content

Java: Query to detect weak encryption: insufficient key size #4926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aschackmull merged 7 commits into from
Feb 3, 2021
Merged

Java: Query to detect weak encryption: insufficient key size #4926

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cfc950f
Query for weak encryption: Insufficient key size
luchua-bc Jan 7, 2021
cbaee93
Optimize the query
luchua-bc Jan 8, 2021
058f3af
Refactor the hasShortSymmetricKey method
luchua-bc Jan 9, 2021
2ac7b4b
Update qldoc
luchua-bc Jan 11, 2021
ab7d257
Add more cases and change EC to 256 bits
luchua-bc Jan 15, 2021
50be543
Update qldoc
luchua-bc Feb 2, 2021
5e3b6fa
Update qldoc
luchua-bc Feb 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update qldoc
  • Loading branch information
@luchua-bc
luchua-bc committed Jan 28, 2021
commit 2ac7b4bab42c4146fb9f629291d049efa43d52e8
14 changes: 7 additions & 7 deletions java/ql/src/experimental/Security/CWE/CWE-326/InsufficientKeySize.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ class KeyPairGeneratorInitConfiguration extends TaintTracking::Configuration {
}
}

/** Holds if a symmetric `KeyGenerator` is initialized with an insufficient key size. */
/** Holds if a symmetric `KeyGenerator` implementing encryption algorithm `type` and initialized by `ma` uses an insufficient key size. `msg` provides a human-readable description of the problem. */
bindingset[type]
predicate hasShortSymmetricKey(MethodAccess ma, string msg, string type) {
ma.getMethod() instanceof KeyGeneratorInitMethod and
Expand All @@ -91,10 +91,10 @@ predicate hasShortSymmetricKey(MethodAccess ma, string msg, string type) {
msg = "Key size should be at least 128 bits for " + type + " encryption."
}

/** Holds if an AES `KeyGenerator` is initialized with an insufficient key size. */
/** Holds if an AES `KeyGenerator` initialized by `ma` uses an insufficient key size. `msg` provides a human-readable description of the problem. */
predicate hasShortAESKey(MethodAccess ma, string msg) { hasShortSymmetricKey(ma, msg, "AES") }

/** Holds if an asymmetric `KeyPairGenerator` is initialized with an insufficient key size. */
/** Holds if an asymmetric `KeyPairGenerator` implementing encryption algorithm `type` and initialized by `ma` uses an insufficient key size. `msg` provides a human-readable description of the problem. */
bindingset[type]
predicate hasShortAsymmetricKeyPair(MethodAccess ma, string msg, string type) {
ma.getMethod() instanceof KeyPairGeneratorInitMethod and
Expand All @@ -111,24 +111,24 @@ predicate hasShortAsymmetricKeyPair(MethodAccess ma, string msg, string type) {
msg = "Key size should be at least 2048 bits for " + type + " encryption."
}

/** Holds if a DSA `KeyPairGenerator` is initialized with an insufficient key size. */
/** Holds if a DSA `KeyPairGenerator` initialized by `ma` uses an insufficient key size. `msg` provides a human-readable description of the problem. */
predicate hasShortDSAKeyPair(MethodAccess ma, string msg) {
hasShortAsymmetricKeyPair(ma, msg, "DSA")
}

/** Holds if a RSA `KeyPairGenerator` is initialized with an insufficient key size. */
/** Holds if a RSA `KeyPairGenerator` initialized by `ma` uses an insufficient key size. `msg` provides a human-readable description of the problem. */
predicate hasShortRSAKeyPair(MethodAccess ma, string msg) {
hasShortAsymmetricKeyPair(ma, msg, "RSA")
}

/** Holds if an EC `KeyPairGenerator` is initialized with an insufficient key size. */
/** Holds if an EC `KeyPairGenerator` initialized by `ma` uses an insufficient key size. `msg` provides a human-readable description of the problem. */
predicate hasShortECKeyPair(MethodAccess ma, string msg) {
ma.getMethod() instanceof KeyPairGeneratorInitMethod and
exists(
JavaSecurityKeyPairGenerator jpg, KeyPairGeneratorInitConfiguration kc,
DataFlow::PathNode source, DataFlow::PathNode dest, ClassInstanceExpr cie
|
jpg.getAlgoSpec().(StringLiteral).getValue().matches("EC%") and //ECC variants such as ECDH and ECDSA
jpg.getAlgoSpec().(StringLiteral).getValue().matches("EC%") and // ECC variants such as ECDH and ECDSA
source.getNode().asExpr() = jpg and
dest.getNode().asExpr() = ma.getQualifier() and
kc.hasFlowPath(source, dest) and
Expand Down