Skip to content

JS: Add ElectronShellOpenExternalSink class for Electron framework security #4546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asgerf merged 3 commits into from
Dec 3, 2020
Merged

JS: Add ElectronShellOpenExternalSink class for Electron framework security #4546

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e87790b
Add ElectronShellOpenExternalSink class
toufik-airane Oct 23, 2020
3ccdc2c
Update ElectronShellOpenExternalSink location
toufik-airane Oct 23, 2020
7d2741a
Add newline
toufik-airane Oct 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions javascript/ql/src/semmle/javascript/security/dataflow/ClientSideUrlRedirect.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,4 +60,15 @@ module ClientSideUrlRedirect {
guard instanceof HostnameSanitizerGuard
}
}

/**
* Improper use of openExternal can be leveraged to compromise the user's host.
* When openExternal is used with untrusted content, it can be leveraged to execute arbitrary commands.
*/
class ElectronShellOpenExternalSink extends Sink {
ElectronShellOpenExternalSink() {
this =
DataFlow::moduleMember("electron", "shell").getAMemberCall("openExternal").getArgument(0)
}
}
}