Skip to content

[WIP] Java: Improve CWE 295 #4536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
intrigus-lgtm wants to merge 5 commits into from
Closed

[WIP] Java: Improve CWE 295 #4536

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2a0a7ad
Separate hostname verification and trustmanger.
intrigus Oct 21, 2020
104accf
Accept test changes and more separation.
intrigus Oct 21, 2020
4210ba8
Switch to dataflow for trust-all verifier.
intrigus Oct 21, 2020
2a0067e
Further separation.
intrigus Oct 21, 2020
e140fb5
Inline `TrueStmt` class
intrigus Dec 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Inline TrueStmt class
  • Loading branch information
@intrigus
intrigus committed Dec 2, 2020
commit e140fb580866e6bbef6312af4b5ff226f4f38dd8
9 changes: 3 additions & 6 deletions java/ql/src/experimental/Security/CWE/CWE-297/UnsafeHostnameVerification.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,13 @@ import java
import semmle.code.java.security.Encryption
import semmle.code.java.dataflow.DataFlow

/** A return statement that returns `true`. */
private class TrueReturnStmt extends ReturnStmt {
TrueReturnStmt() { getResult().(CompileTimeConstantExpr).getBooleanValue() = true }
}

/**
* Holds if `m` always returns `true` ignoring any exceptional flow.
*/
private predicate alwaysReturnsTrue(HostnameVerifierVerify m) {
forex(ReturnStmt rs | rs.getEnclosingCallable() = m | rs instanceof TrueReturnStmt)
forex(ReturnStmt rs | rs.getEnclosingCallable() = m |
rs.getResult().(CompileTimeConstantExpr).getBooleanValue() = true
)
}

/**
Expand Down