C++: Annotate IR with partial flow info#4501
Merged
Merged
Conversation
I've added one more property to the annotations provided by `PrintIRLocalFlow.qll`: The `pflow` property will now be emitted for any operand or instruction for which `configuration.hasPartialFlow` determines that there is partial flow to that node. This requires that partial flow be enabled via overriding `Configuration::explorationLimit()` in order to display. Otherwise, you'll still just get the local flow info as before.
MathiasVP
reviewed
Oct 17, 2020
Contributor
MathiasVP
left a comment
There was a problem hiding this comment.
LGTM! I've never really found much use of the distance information when using partial flow, so I'd be totally okay with not having it in the output.
But if you have found it useful I won't object to having it included :)
MathiasVP
approved these changes
Oct 18, 2020
Author
|
The distance seems to always be zero. The only time I saw it be something else was when I was still accidentally including non-local flow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added one more property to the annotations provided by
PrintIRLocalFlow.qll: Thepflowproperty will now be emitted for any operand or instruction for whichconfiguration.hasPartialFlowdetermines that there is partial flow to that node. This requires that partial flow be enabled via overridingConfiguration::explorationLimit()in order to display. Otherwise, you'll still just get the local flow info as before.