JavaScript: Introduce aliases for compatibility with other language libraries.#445
Merged
Merged
Conversation
ghost
approved these changes
Nov 9, 2018
ghost
left a comment
There was a problem hiding this comment.
LGTM
In future PRs, do we want to be strict about not using the aliases unless absolutely necessary?
Author
|
I'll probably stick to the original names, but if you prefer to use the aliases that's fine by me. |
cklin
pushed a commit
that referenced
this pull request
May 23, 2022
Add 'git' as a possible command-interpreter, unless arguments are sanitized using "--"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following a suggestion by @lukecartey.
For now, this only covers some basic AST classes and introduces aliases for similar classes in the C#, C++ and Java libraries; suggestions for further additions welcome.