Skip to content

JavaScript: Improve StackTraceExposure query.#443

Merged
semmle-qlci merged 1 commit into
github:masterfrom
xiemaisi:js/improve-stack-trace-exposure
Nov 12, 2018
Merged

JavaScript: Improve StackTraceExposure query.#443
semmle-qlci merged 1 commit into
github:masterfrom
xiemaisi:js/improve-stack-trace-exposure

Conversation

@xiemaisi

@xiemaisi xiemaisi commented Nov 9, 2018

Copy link
Copy Markdown

It now also flags exposure of the entire exception object (not just the stack property).

It now also flags exposure of the entire exception object (not just the `stack` property).
@xiemaisi xiemaisi added the JS label Nov 9, 2018
@xiemaisi xiemaisi requested a review from a team as a code owner November 9, 2018 09:42
@xiemaisi

xiemaisi commented Nov 9, 2018

Copy link
Copy Markdown
Author

Motivated by findings at a customer's.

@asger-semmle asger-semmle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@semmle-qlci semmle-qlci merged commit c9d77a2 into github:master Nov 12, 2018
@xiemaisi xiemaisi deleted the js/improve-stack-trace-exposure branch November 12, 2018 09:18
cklin pushed a commit that referenced this pull request May 23, 2022
…es-2021-01

Add change-notes for recent PRs that were missing them
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants