C#: Correctly handle in arguments#437
Merged
Merged
Conversation
hvitved
previously approved these changes
Nov 8, 2018
Contributor
hvitved
left a comment
There was a problem hiding this comment.
Nice and simple, perfect! :-)
Contributor
|
Happy to merge after a rebase. |
e0f358a to
9f04ace
Compare
hvitved
approved these changes
Nov 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation of C# 7.2
inparameters was incomplete because it didn't test that expressions passed asinarguments were extracted correctly. In fact, the extractor completely failed to extractinarguments, resulting inUnknown argument typeerrors incsharp.log.This PR fixes the C# extractor to recognise the
inkeyword, and creates a newexpr_argumentvalue3to indicate that the argument is passed asin. The dbscheme does not need to change.Update the QL tests and libraries.