Allow mixed whitespace in certain test and external directories#418
Conversation
| [ | ||
| { | ||
| "pattern": "**/*.cs", | ||
| "allowMixedTabsAndSpaces": true |
There was a problem hiding this comment.
I would prefer if none of the test files had mixed spaces; isn't that the case today?
There was a problem hiding this comment.
My initial reaction is the same for the java test files; I don't think they should have mixed ws either.
There was a problem hiding this comment.
For C++ we allow mixed whitespace in test source files because we want to run our tests not only on neatly formatted input but also on ugly and realistic files.
There was a problem hiding this comment.
Right. And I guess there can be queries of a more syntactic nature where it matters. So it's probably fine to whitelist the tests.
487440f to
f98bf8a
Compare
|
I believe this is now ready for review. I've allowed mixed whitespace in test sources for all languages (including the JavaScript extractor tests). I've also allowed mixed whitespace for all files in the |
203af13 to
2977395
Compare
|
@hvitved, are you happy for this PR to be merged? |
No description provided.