Skip to content

Java: Adjust a few qltests. #4175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codeql-ci merged 1 commit into from
Sep 1, 2020
Merged

Java: Adjust a few qltests. #4175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion java/ql/test/query-tests/security/CWE-089/semmle/examples/controlledString.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@ where
controlledString(controlled) and
method = controlled.getEnclosingCallable() and
line = controlled.getLocation().getStartLine() - method.getLocation().getStartLine() and
controlled.getCompilationUnit().fromSource()
controlled.getCompilationUnit().fromSource() and
controlled.getFile().getStem() = ["Test", "Validation"]
select method.getName(), line, controlled
5 changes: 4 additions & 1 deletion java/ql/test/query-tests/security/CWE-089/semmle/examples/endsInQuote.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
import semmle.code.java.security.ControlledString

from Expr precedes, Method method
where endsInQuote(precedes) and precedes.getEnclosingCallable() = method
where
endsInQuote(precedes) and
precedes.getEnclosingCallable() = method and
precedes.getFile().getStem() = "Test"
select method.getName(),
precedes.getLocation().getStartLine() - method.getLocation().getStartLine(), precedes
5 changes: 4 additions & 1 deletion java/ql/test/query-tests/security/CWE-089/semmle/examples/taintedString.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,8 @@ class Conf extends TaintTracking::Configuration {
}

from Conf conf, Expr tainted, Method method
where conf.hasFlowToExpr(tainted) and tainted.getEnclosingCallable() = method
where
conf.hasFlowToExpr(tainted) and
tainted.getEnclosingCallable() = method and
tainted.getFile().getStem() = ["Test", "Validation"]
select method, tainted.getLocation().getStartLine() - method.getLocation().getStartLine(), tainted