Java: Customizable XSS analysis#4172
Merged
Merged
Conversation
Turn the Xss sanitizer into an abstract class to support customizations and provide a default implementation.
aschackmull
requested changes
Aug 31, 2020
Contributor
aschackmull
left a comment
There was a problem hiding this comment.
A few comments on the qldoc. Otherwise LGTM.
Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com>
aschackmull
approved these changes
Sep 1, 2020
aschackmull
added a commit
to aschackmull/ql
that referenced
this pull request
Oct 29, 2020
This covers github#3928, github#3968, and github#4172, among others.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR abstracts the sanitizer and additional taint step of the XSS analysis to enable customization.
The existing implementation is moved into a default implementation of these abstractions.