JavaScript: Make PromiseFlow module public.#4171
Merged
Merged
Conversation
erik-krogh
approved these changes
Aug 31, 2020
Contributor
erik-krogh
left a comment
There was a problem hiding this comment.
since that seems to require importing an internal module in order to be able to access
StoreStep.
That is correct.
I think it is OK to do the private import inside your library code, but I can definitely see why you would want to make PromiseFlow public instead of importing an internal module.
PromiseFlow is also sufficiently documented that it looks OK to me to make it public.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #4082, I'd like to use
PromiseFlow::storeStepdirectly instead of going viaPromiseTypeTracking::promiseStep, since that seems to require importing an internal module in order to be able to accessStoreStep. (Or perhaps there is a better way of achieving the same thing?)