cpp: Incorrect not operator usage#416
Merged
Merged
Conversation
Marked as Low precision as Linux kernel code mix the usage of logical operators and bit-wise opeartors. warning C6317: incorrect operator: logical-not (!) is not interchangeable with ones-complement (~)
geoffw0
reviewed
Nov 7, 2018
Contributor
geoffw0
left a comment
There was a problem hiding this comment.
LGTM.
The results I'm seeing for & and I appear to be good quality, whereas many results for ^ and >>/<< are questionable. Have you considered restricting the query to just BitwiseAndExpr + BitwiseOrExpr, which might perhaps justify a precision of medium?
Would there be value in covering the opposite case, i && ~FLAGS?
Restricting to analyze only logical & and | operations
geoffw0
approved these changes
Nov 9, 2018
Contributor
geoffw0
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you for working on this new query!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marked as Low precision as Linux kernel code mix the usage of logical operators and bit-wise opeartors.
warning C6317: incorrect operator: logical-not (!) is not interchangeable with ones-complement (~)