JavaScript: Tweak a few predicates in the data flow library.#406
Merged
Conversation
Contributor
|
It's not fresh in memory obviously but I still have the some log files from that line of work. Based on the date of the commit, I believe it fixed the last three projects in this run. |
Author
|
OK, those are all in the default suite, so something else (or one of the other two commits in this PR) must have fixed them even without the noopt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During a recent customer visit, we noticed that a
pragma[noopt]introduced by @asger-semmle in 0936cda was forcing a very bad join order, so I removed it (first commit). I also introduced two annotations to avoid unhelpful magic (second commit and third commit), and extracted an auxiliary predicate to enable a better join order (third commit).On
default.slugs, these three changes together have no impact on performance or results, but they do improve performance quite a bit on said customer's code base, and I'm always happy when I can remove a noopt.@asger-semmle, do you remember where you observed the slow join that caused you to introduce the pragma in the first place? Was it one of our default projects?