Java: Make XssSink extensible.#4042
Merged
Merged
Conversation
aibaars
reviewed
Aug 31, 2020
| } | ||
|
|
||
| class ServletWriterSourceToWritingMethodFlowConfig extends TaintTracking::Configuration { | ||
| private class ServletWriterSourceToWritingMethodFlowConfig extends TaintTracking2::Configuration { |
Contributor
There was a problem hiding this comment.
What's the reason for using TaintTracking2 versus TaintTracking ?
Contributor
Author
There was a problem hiding this comment.
The result of this configuration is used in the definition of XssSink. So this config must come from a different library copy than any config that uses XssSink (otherwise we'd have negative recursion through the dataflow library). In this PR I simply switch use of the two copies around, such that the queries can use the default copy.
aibaars
approved these changes
Aug 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
XssSinkan abstract class such that it can be extended. I've also included some minor cleanup such thatXSS.qlldoesn't claim the canonical dataflow library.