Skip to content

C++: QLDoc cleanup#3860

Merged
jbj merged 4 commits into
github:masterfrom
dbartol:codeql-c-analysis-team/40/2
Jul 2, 2020
Merged

C++: QLDoc cleanup#3860
jbj merged 4 commits into
github:masterfrom
dbartol:codeql-c-analysis-team/40/2

Conversation

@dbartol
Copy link
Copy Markdown

@dbartol dbartol commented Jun 30, 2020

This PR just fixes a few bits of PR feedback from my previous QLDoc PR.

This PR just fixes a few bits of PR feedback from my previous QLDoc PR.
@dbartol dbartol added the C++ label Jun 30, 2020
@dbartol dbartol requested review from a team as code owners June 30, 2020 21:34
geoffw0
geoffw0 previously approved these changes Jul 1, 2020
Copy link
Copy Markdown
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoffw0
Copy link
Copy Markdown
Contributor

geoffw0 commented Jul 1, 2020

Autoformat unaliased_ssa/IRBlock.qll.

Copy link
Copy Markdown
Contributor

@jbj jbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

Comment thread cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/IRBlock.qll Outdated
@jbj jbj merged commit 62a656d into github:master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants