JavaScript: Fix modelling of _.partial.#386
Merged
Merged
Conversation
ghost
reviewed
Oct 31, 2018
ghost
left a comment
There was a problem hiding this comment.
LGTM, except for the benign test failure.
| @@ -1,13 +1,13 @@ | |||
| WARNING: Predicate flowsFrom has been deprecated and may be removed in future (ReflectedXssWithCustomSanitizer_old.ql:21,11-20) | |||
There was a problem hiding this comment.
Jenkins failure: you need to use a different version of /code to get the samme warning order.
Contributor
|
Thanks for catching that. I thought I tested it, but I think I was tricked by a coercion: function f(x,y) { console.log(x + y) }
_.partial(f, ["hello"])("world") |
4b8432c to
896a027
Compare
Like `Function.prototype.bind` (but unlike `ramda.partial`) it takes the curried arguments as rest arguments, not as an array; cf. https://lodash.com/docs/4.17.10#partial and https://underscorejs.org/#partial.
896a027 to
c75d785
Compare
Author
|
Amended and added a change note. |
ghost
approved these changes
Nov 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like
Function.prototype.bind(but unlikeramda.partial) it takes the curried arguments as rest arguments, not as an array; cf. https://lodash.com/docs/4.17.10#partial and https://underscorejs.org/#partial.