C#: Factor C++ parts out of autobuilder#3846
Merged
Merged
Conversation
671c927 to
398a95c
Compare
rdmarsh2
approved these changes
Jul 1, 2020
Contributor
rdmarsh2
left a comment
There was a problem hiding this comment.
Looks good to me. I'll give @calumgrant a chance to give his feedback as well.
calumgrant
suggested changes
Jul 2, 2020
Contributor
calumgrant
left a comment
There was a problem hiding this comment.
Overall LGTM - a small suggestion.
| class BuildCommandAutoRule : IBuildRule | ||
| public class BuildCommandAutoRule : IBuildRule | ||
| { | ||
| private readonly Func<Autobuilder, Func<IDictionary<string, string>?, BuildScript>, BuildScript> withDotNet; |
Contributor
There was a problem hiding this comment.
Func<Autobuilder, Func<IDictionary<string, string>?, BuildScript>, BuildScript> could be turned into a delegate as it's written out 4 times.
calumgrant
approved these changes
Jul 2, 2020
Contributor
calumgrant
left a comment
There was a problem hiding this comment.
Agreed to make changes in follow-up. Thanks Tom!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal PR: https://git.semmle.com/Semmle/code/pull/37210.