Skip to content

C++: IR return indirections for this #3587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbj merged 16 commits into from
Jun 17, 2020
Merged

C++: IR return indirections for this #3587

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
7dc30e3
C++: add output indirections for `this`
May 28, 2020
a897cae
C++: outbound dataflow via `this` indirections
May 28, 2020
a638a08
C++: autoformat
May 29, 2020
f8cfcef
C++/C#: document isThisIndirection and sync files
May 29, 2020
5ee37bc
Merge branch 'master' into ir-this-parameter-2
May 29, 2020
45e555c
C++: accept inconsistency with unreachable exit block
May 29, 2020
f7752b0
C++/C#: add IRParameter subclass of IRVariable
Jun 3, 2020
0d2f8f3
Merge branch 'master' into ir-this-parameter-2
Jun 5, 2020
53a87fa
C++: accept field flow test changes after merge
Jun 5, 2020
cce99f9
C++: exclude conversions in IR field flow tests
Jun 5, 2020
2a96856
C++/C#: Document IRPositionalParameter
Jun 8, 2020
a7efa0d
Merge branch 'master' into ir-this-parameter-2
Jun 11, 2020
65f4ef7
C++: accept false positive tests after merge
Jun 11, 2020
1c9b6f0
Merge branch 'master' into ir-this-parameter-2
Jun 16, 2020
0c99b36
C++: remove false negative comments in swap tests
Jun 16, 2020
ef940e8
C++: Add comment for false positives in swap tests
Jun 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
C++: accept false positive tests after merge 
The IR false positives are due to the same path length limit as the AST
false positives on the same line.
  • Loading branch information
Robert Marsh committed Jun 11, 2020
commit 65f4ef712e182702ac5c383129e8767f51a32958
4 changes: 2 additions & 2 deletions cpp/ql/test/library-tests/dataflow/fields/complex.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ void bar(Outer &b)
// in _some_ access path somewhere in the search. That makes the library conclude
// that there could be flow to `b.inner.f.a_` even when the flow was actually to
// `b.inner.f.b_`.
sink(b.inner.f.a()); // $ast=62:19 $f+:ast=63:19 $ast=64:19 $f+:ast=65:19 $ir=62:19 $ir=64:19
sink(b.inner.f.b()); // $f+:ast=62:19 $ast=63:19 $f+:ast=64:19 $ast=65:19 $ir=63:19 $ir=65:19
sink(b.inner.f.a()); // $ast=62:19 $f+:ast=63:19 $ast=64:19 $f+:ast=65:19 $ir=62:19 $f+:ir=63:19 $ir=64:19 $f+:ir=65:19
sink(b.inner.f.b()); // $f+:ast=62:19 $ast=63:19 $f+:ast=64:19 $ast=65:19 $f+:ir=62:19 $ir=63:19 $f+:ir=64:19 $ir=65:19
}

void foo()
Expand Down
4 changes: 0 additions & 4 deletions cpp/ql/test/library-tests/dataflow/fields/ir-flow.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +0,0 @@
| complex.cpp:51:18:51:18 | call to a | Unexpected result: ir=63:19 |
| complex.cpp:51:18:51:18 | call to a | Unexpected result: ir=65:19 |
| complex.cpp:52:18:52:18 | call to b | Unexpected result: ir=62:19 |
| complex.cpp:52:18:52:18 | call to b | Unexpected result: ir=64:19 |