C++: Test field conflation with array in struct#3475
Merged
Conversation
MathiasVP
approved these changes
May 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test for a field conflation issue that's currently blocking #3123. It turns out the issue is present already without #3123, and it can be distilled down to this test case. I've added the test case both in the library test and a query test.
I think the fundamental problem the interaction between
codeql/cpp/ql/src/semmle/code/cpp/ir/dataflow/DefaultTaintTracking.qll
Lines 236 to 237 in 23532ae
codeql/cpp/ql/src/semmle/code/cpp/ir/dataflow/DefaultTaintTracking.qll
Lines 224 to 226 in 23532ae
but I haven't investigated that. EDIT: This was not the issue.