JS: introduce Expr:getUnderlyingX#345
Merged
Merged
Conversation
xiemaisi
suggested changes
Oct 23, 2018
xiemaisi
left a comment
There was a problem hiding this comment.
Basically fine, modulo some details. I'm not entirely sure about the "value" terminology, given that the predicate returns an expression, but I guess it makes sense in tandem with "reference".
Author
|
Comments addressed. |
xiemaisi
reviewed
Oct 23, 2018
|
|
||
| /** | ||
| * Gets the innermost reference that this expression evaluates to, if any. | ||
| * For example, `o.m` of `(o.m)`, but not of `(0, o.m)`. |
There was a problem hiding this comment.
I'd prefer a more complete listing of all covered cases (also for getUnderlyingValue).
xiemaisi
previously approved these changes
Oct 24, 2018
Author
|
Rebased to resolve expected output conflict. |
xiemaisi
previously approved these changes
Oct 26, 2018
added 7 commits
October 29, 2018 09:22
xiemaisi
approved these changes
Oct 30, 2018
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Apr 16, 2022
Merge main into kotlin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
Expr::getUnderlyingValueand its siblingExpr::getUnderlyingReferenceas the semantic versions of whatExpr::stripParensmost often is used for.I have two unopened PRs that make use of the features of this PR, so I would like it merged soon.
I have another stack of commits that replace most
Expr::stripParensuses withExpr::getunderlyingValueandExpr:getUnderlyingReferencethroughout the code base. But I would like to wait with merging that since the performance evaluation of that is unstable, and since a timeout has started to consistently happen on the base commit as well.