Skip to content

JS: Move getContainer to single rootdef (+fixes) #3403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asgerf merged 8 commits into from
May 6, 2020
Merged

JS: Move getContainer to single rootdef (+fixes) #3403

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5f710bc
JS: Move definition of getContainer() to a single rootdef
asgerf May 1, 2020
e52e1b2
JS: Upgrade script
asgerf May 1, 2020
639f043
JS: Avoid bad join ordering in ClosureModule
asgerf May 1, 2020
4d6da19
JS: Improve performance of getExceptionTarget
asgerf May 1, 2020
0f870a4
JS: Use TCapturedVariableNode as starting point of callInputStep
asgerf May 1, 2020
f51e846
JS: Fix ClosureModule implementation
asgerf May 4, 2020
926e79d
JS: Autoformat
asgerf May 4, 2020
b2da4fe
Update javascript/ql/src/semmle/javascript/internal/StmtContainers.qll
asgerf May 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
JS: Avoid bad join ordering in ClosureModule
  • Loading branch information
@asgerf
asgerf committed May 6, 2020
commit 639f04386c9716c422585f9a7678c1d5e46b55e8
23 changes: 17 additions & 6 deletions javascript/ql/src/semmle/javascript/Closure.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,17 +115,28 @@ module Closure {
override DefaultClosureModuleDeclaration range;
}

private GlobalVariable googVariable() {
variables(result, "goog", any(GlobalScope sc))
}

pragma[nomagic]
private MethodCallExpr googModuleDeclExpr() {
result.getReceiver() = googVariable().getAnAccess() and
result.getMethodName() = ["module", "declareModuleId"]
}

pragma[nomagic]
private MethodCallExpr googModuleDeclExprInContainer(StmtContainer container) {
result.getReceiver() = googModuleDeclExpr() and
container = result.getContainer()
}

/**
* A module using the Closure module system, declared using `goog.module()` or `goog.declareModuleId()`.
*/
class ClosureModule extends Module {
ClosureModule() {
// Use AST-based predicate to cut recursive dependencies.
exists(MethodCallExpr call |
getAStmt().(ExprStmt).getExpr() = call and
call.getReceiver().(GlobalVarAccess).getName() = "goog" and
(call.getMethodName() = "module" or call.getMethodName() = "declareModuleId")
)
exists(googModuleDeclExprInContainer(this))
}

/**
Expand Down