Skip to content

Java: Add a query for MVEL injections #3329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aschackmull merged 10 commits into from
Jun 8, 2020
Merged

Java: Add a query for MVEL injections #3329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c6c4c2c
Java: Add a query for MVEL injections
artem-smotrakov Apr 23, 2020
32ff5ad
Java: Added CompiledExpression sink for MVEL injections
artem-smotrakov Apr 24, 2020
12e0234
Java: Added CompiledAccExpression sink for MVEL injections
artem-smotrakov Apr 24, 2020
6a6c805
Java: Added Accessor sink for MVEL injections
artem-smotrakov Apr 24, 2020
8fd7265
Java: Added JSR 223 sinks for MVEL injections
artem-smotrakov Apr 25, 2020
fa717b2
Java: Added template sinks for MVEL injections
artem-smotrakov May 1, 2020
df9d10f
Java: Added MVELRuntime.execute() sink for MVEL injections
artem-smotrakov May 1, 2020
4a83fb8
Java: Simplified MvelInjection test
artem-smotrakov May 1, 2020
2842aee
Java: Simplified MvelInjectionLib
artem-smotrakov May 31, 2020
b7c3dd6
Java: Clean up MVEL injection query
artem-smotrakov Jun 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions java/ql/src/experimental/Security/CWE/CWE-094/MvelInjection.qhelp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
<!DOCTYPE qhelp PUBLIC "-//Semmle//qhelp//EN" "qhelp.dtd">
<qhelp>

<overview>
<p>
MVEL is an expression language based on Java-syntax.
The language offers many features
including invocation of methods available in the JVM.
If a MVEL expression is built using attacker-controlled data,
and then evaluated, then it may allow the attacker to run arbitrary code.
</p>
</overview>

<recommendation>
<p>
Including user input in a MVEL expression should be avoided.
</p>
</recommendation>

<example>
<p>
The following example uses untrusted data to build a MVEL expression
and then runs it in the default powerfull context.
</p>
<sample src="UnsafeMvelExpressionEvaluation.java" />
</example>

@aschackmull aschackmull Jun 5, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</example>

Missing close tag.

<references>
<li>
MVEL Documentation:
<a href="http://mvel.documentnode.com/">Language Guide for 2.0</a>.
</li>
<li>
OWASP:
<a href="https://owasp.org/www-community/vulnerabilities/Expression_Language_Injection">Expression Language Injection</a>.
</li>
</references>
</qhelp>
19 changes: 19 additions & 0 deletions java/ql/src/experimental/Security/CWE/CWE-094/MvelInjection.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
/**
* @name Expression language injection (MVEL)
* @description Evaluation of a user-controlled MVEL expression
* may lead to remote code execution.
* @kind path-problem
* @problem.severity error
* @precision high
* @id java/mvel-expression-injection
* @tags security
* external/cwe/cwe-094
*/

import java
import MvelInjectionLib
import DataFlow::PathGraph

from DataFlow::PathNode source, DataFlow::PathNode sink, MvelInjectionConfig conf
where conf.hasFlowPath(source, sink)
select sink.getNode(), source, sink, "MVEL injection from $@.", source.getNode(), "this user input"
Loading