Python: Autoformat all .ql files.#3156
Merged
Merged
Conversation
How could the tests fail because of autoformatting, you may ask? The answer is deprecation warnings. These specify the location of the deprecated entity, and due to autoformatting these moved around.
RasmusWL
approved these changes
Mar 30, 2020
Member
RasmusWL
left a comment
There was a problem hiding this comment.
I looked at some ~20 files, and it all looks good to me!
| predicate does_nothing(PyFunctionObject f) { | ||
| not exists(Stmt s | s.getScope() = f.getFunction() | | ||
| not s instanceof Pass and not ((ExprStmt)s).getValue() = f.getFunction().getDocString() | ||
| not s instanceof Pass and not s.(ExprStmt).getValue() = f.getFunction().getDocString() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did not vet these files as thoroughly as the
.qllfiles, but I don't think it's likely that there are any problems hiding in these.I would suggest looking at a few random files, and if nothing looks out of order just going ahead with the merge. We can always fix up any problems at a later date.