Data flow: No magic in returnFlowCallableCand#3142
Merged
aschackmull merged 2 commits intoMar 30, 2020
Conversation
Contributor
Author
Contributor
|
LGTM. Now that you are implementing field-flow for C++, I'd be interested to see which effect #3110 has. It has a positive performance impact on large Java and C# projects, but performance for C++ was mostly unchanged. |
Contributor
Author
MathiasVP
added a commit
to MathiasVP/ql
that referenced
this pull request
Mar 28, 2020
jbj
approved these changes
Mar 30, 2020
Contributor
jbj
left a comment
There was a problem hiding this comment.
LGTM. @aschackmull, do you have any objection to merging this?
aschackmull
approved these changes
Mar 30, 2020
max-schaefer
pushed a commit
to max-schaefer/codeql-go
that referenced
this pull request
Mar 30, 2020
max-schaefer
pushed a commit
to max-schaefer/codeql-go
that referenced
this pull request
May 6, 2020
max-schaefer
pushed a commit
to max-schaefer/codeql-go
that referenced
this pull request
May 6, 2020
owen-mc
pushed a commit
to owen-mc/codeql-go
that referenced
this pull request
Jun 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding implementations of
PostUpdateNodefor IR field flow in C++ (#3118) revealed a bad join order inDataFlowImpl::parameterThroughFlowCandwhen running onWireshark/Wireshark:The fix is to avoid inlining
returnFlowCallableCand. I couldn't reproduce the bad join order in C++ without the changes in #3118, but I figured it'd be good to test the impact of this change onmasterin isolation.