C++: Downgrade cpp/incomplete-parity-check from high to medium precision [CPP-236]#30
Merged
Merged
Conversation
As reported in CPP-236, this query has false positives on signed integers that cannot be negative. It could possibly be improved with a local range analysis, but the query would most likely still have so many false positives that we would have to lower its precision. Under our current policy, this change will make the query hidden by default on LGTM.
Contributor
|
I agree this query, while informative in principle, has a lot of weak results in practice. This is typical of the results I found: Merging... |
aibaars
added a commit
that referenced
this pull request
Oct 14, 2021
Get latest fixes from tree-sitter-ruby repo
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Oct 28, 2021
Fix DB relation names to use plurals
erik-krogh
pushed a commit
to erik-krogh/ql
that referenced
this pull request
Dec 15, 2021
Add AST nodes for QLDoc
erik-krogh
pushed a commit
to erik-krogh/ql
that referenced
this pull request
Dec 15, 2021
Add AST nodes for QLDoc
dbartol
pushed a commit
that referenced
this pull request
Dec 18, 2024
Improve UntrustedCheckout query
dbartol
pushed a commit
that referenced
this pull request
Dec 18, 2024
…ion_model Add missing source for peter-murray/issue-body-parser-action
MathiasVP
pushed a commit
to MathiasVP/ql
that referenced
this pull request
Aug 10, 2025
(cherry picked from commit bdae2af)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in CPP-236, this query has false positives on signed integers that cannot be negative. It could possibly be improved with a local range analysis, but the query would most likely still have so many false positives that we would have to lower its precision.
Under our current policy, this change will make the query hidden by default on LGTM.