Skip to content

C#: Convert tests/query-tests/Stubs/Test.cs to Unix line endings.#297

Merged
semmle-qlci merged 1 commit into
github:masterfrom
xiemaisi:csharp/line-endings
Oct 9, 2018
Merged

C#: Convert tests/query-tests/Stubs/Test.cs to Unix line endings.#297
semmle-qlci merged 1 commit into
github:masterfrom
xiemaisi:csharp/line-endings

Conversation

@xiemaisi
Copy link
Copy Markdown

@xiemaisi xiemaisi commented Oct 9, 2018

No description provided.

@xiemaisi xiemaisi requested a review from a team as a code owner October 9, 2018 12:01
@hvitved
Copy link
Copy Markdown
Contributor

hvitved commented Oct 9, 2018

I thought .gitattributes should take care of this automatically?

@xiemaisi
Copy link
Copy Markdown
Author

xiemaisi commented Oct 9, 2018

It didn't for me. Do I need to do anything special in order for it to work?

@hvitved
Copy link
Copy Markdown
Contributor

hvitved commented Oct 9, 2018

It didn't for me. Do I need to do anything special in order for it to work?

@dave-bartolomeo : Can you help us out?

@dave-bartolomeo
Copy link
Copy Markdown
Contributor

@xiemaisi Is it possible that this file was originally committed in a branch that did not yet have the .gitattributes changes, then merged into master later?

@semmle-qlci semmle-qlci merged commit b1ece81 into github:master Oct 9, 2018
@xiemaisi
Copy link
Copy Markdown
Author

Is it possible that this file was originally committed in a branch that did not yet have the .gitattributes changes, then merged into master later?

Ah, that must be it. I think this file was introduced by https://github.com/Semmle/ql/tree/593f0a9d71a5bcd2e0b0350c171f15053cb00c47, which only had line ending normalisation for QL files.

@xiemaisi xiemaisi deleted the csharp/line-endings branch October 16, 2018 07:54
aibaars added a commit that referenced this pull request Oct 14, 2021
Alert suppression and file classifier query
smowton pushed a commit to smowton/codeql that referenced this pull request Apr 16, 2022
Fix generic constructor reference extraction
MathiasVP pushed a commit to MathiasVP/ql that referenced this pull request Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants