C++: Support dynamic memory allocations in IR alias analysis#2797
Merged
Conversation
rdmarsh2
commented
Feb 8, 2020
Contributor
Author
rdmarsh2
left a comment
There was a problem hiding this comment.
I have a few TODOs added early that didn't seem to cause any issues, but I'd like a second look at them before I take them out
dbartol
reviewed
Feb 10, 2020
dbartol
left a comment
There was a problem hiding this comment.
Mostly LGTM. I'll do a final pass once you've taken it out of Draft status and the tests are passing.
geoffw0
reviewed
Feb 12, 2020
dbartol
previously approved these changes
Feb 13, 2020
Contributor
Author
|
https://jenkins.internal.semmle.com/job/Changes/job/CPP-Differences/869/ finished - the analysis with this change was about 5% faster on Wireshark and ChakraCore. That might be noise or it might be from having fewer references to all aliased memory in SSA construction. |
jbj
approved these changes
Mar 2, 2020
Contributor
jbj
left a comment
There was a problem hiding this comment.
The internal tests have passed, so I'll merge this now.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new opcode,
InitializeDynamicAllocation, adds it to IR generation for statically-resolvable calls toAllocationFunctions, and adds a newAllocationsubtype in the aliased_ssa version ofAliasConfiguration.qll.