C#: Add missing toString() relations#2538
Merged
Merged
Conversation
ee2ea91 to
f1193d0
Compare
calumgrant
approved these changes
Dec 17, 2019
Contributor
calumgrant
left a comment
There was a problem hiding this comment.
A small question but otherwise LGTM
| | queries.cs:27:11:27:42 | call to method Join | 2 | queries.cs:27:21:27:25 | access to local variable list1 | | ||
| | queries.cs:27:11:27:42 | call to method Join | 3 | queries.cs:27:30:27:33 | access to local variable next | | ||
| | queries.cs:27:11:27:42 | call to method Join | 4 | queries.cs:27:42:27:42 | access to local variable c | | ||
| | queries.cs:28:11:28:18 | call to method | 0 | queries.cs:27:11:27:42 | call to method Join | |
Contributor
There was a problem hiding this comment.
Why not call to method Join ?
Contributor
Author
There was a problem hiding this comment.
Actually, it is a call to Select that is missing. It appears to be a Roslyn bug: this call always return null for LINQ expressions containing joins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2518.