C#: add linux-arm64 to standalone_dependencies assembly path normalization - #22348
Merged
Conversation
…ation Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Linux ARM64 path normalization to keep the C# assembly integration test platform-independent.
Changes:
- Includes
linux-arm64in recognized extractor tool paths. - Preserves existing architecture-independent expected output.
Show a summary per file
| File | Description |
|---|---|
csharp/ql/integration-tests/posix/standalone_dependencies_executing_runtime/Assemblies.ql |
Normalizes Linux ARM64 tool assembly paths. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Assemblies.qlintegration-test query normalizes absolute paths of extractor tool assemblies so the expected output is platform independent. It did this only forosx64andlinux64, so onlinux-arm64(where the C# extractor tools live undercsharp/tools/linux-arm64/) those tool assembly paths were not normalized and got dropped from the results.This adds
linux-arm64to the architecture list used for path normalization. The managed assembly set is architecture independent, so the expected output is unchanged andAssemblies.expectedneeds no update.